Fixes special characters and only downloads du.exe on Windows#5
Merged
Conversation
SpraxDev
force-pushed
the
two-little-fixes
branch
from
e30aa27 to
2fd8ccf
Compare
Contributor
Author
|
Sorry for failed test 😅 |
simoneb
approved these changes
Apr 15, 2021
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻
I've forked your project and recoded parts of it in TypeScript for my own needs - Maybe you want to check out my improvements.
This PR contains 2 little fixes:
duon.allows us to avoid escaping the path - Putting it inside"might help in most cases but if doesn't break on Windows, it does on Linux/ext as"is a valid character to use.du.exeonto a system that doesn't use it anyway