-
Notifications
You must be signed in to change notification settings - Fork 71
Support GHC 9.14.1, base-4.22, and regenerate CI #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
plus corresponding CI additions
| tested-with: | ||
| GHC == 9.14.1 | ||
| GHC == 9.12.2 | ||
| GHC == 9.10.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not bump this to 9.10.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only to avoid making more changes than necessary, happy to do it this evening if we prefer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think when updating CI it makes sense to always bump to all latest minor GHC versions.
The rationale is that the other minor versions are essentially deprecated.
|
CI failure |
|
@simonmar wrote:
Please rerun the failed workflow, I updated |
|
sorry about that, don't know how it passed in my PR but failed here :( |
| tested-with: | ||
| GHC == 9.14.1 | ||
| GHC == 9.12.2 | ||
| GHC == 9.10.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think when updating CI it makes sense to always bump to all latest minor GHC versions.
The rationale is that the other minor versions are essentially deprecated.
|
I relaxed the However, I think this package should be released anyway to sync the repo with the hackage publication. |
Per CI in my own fork it doesn't seem like any changes are necessary, but I admit I didn't read the changelogs carefully.
base changelog: https://hackage.haskell.org/package/base-4.22.0.0/changelog