zoxide: remove completions workaround #34
Merged
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes a workaround that manually cleared fish shell's built-in autojump completions before initializing zoxide. The workaround is no longer necessary as the fix has been incorporated into zoxide itself via PR #1165.
Changes:
- Removed the
complete -c j -ecommand that cleared autojump completions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The workaround to clear fish's built-in autojump completions is no longer needed once zoxide includes the fix from: ajeetdsouza/zoxide#1165 Merge this PR after a new zoxide release. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
simono
force-pushed
the
remove-zoxide-workaround
branch
from
a4d2777 to
39332a5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the workaround that clears fish's built-in autojump completions before zoxide init.
This workaround is no longer needed once zoxide includes the fix from:
ajeetdsouza/zoxide#1165
When to merge
Merge this PR after a new zoxide release that includes the fix.
🤖 Generated with Claude Code