Conversation
There was a problem hiding this comment.
Pull request overview
Removes the rose-pine/pure Fisher plugin and the explicit rose_pine_pure $theme_variant invocation, relying instead on rose-pine/fish to apply Pure prompt colors reactively via its conf.d hooks.
Changes:
- Removed
rose-pine/purefrom the Fisher plugin list. - Removed the manual Pure prompt color configuration call from
fish/conf.d/theme.fish.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
fish/fish_plugins |
Drops the rose-pine/pure plugin dependency from the plugin set. |
fish/conf.d/theme.fish |
Removes the manual Pure prompt color application hook. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pure prompt colors are now reactively applied via --on-variable handlers in the rose-pine/fish conf.d integration. No manual rose_pine_pure call needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simono
force-pushed
the
remove-rose-pine-pure-plugin
branch
from
452edbb to
4467834
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rose-pine/pureFisher pluginrose_pine_pure $theme_variantcall fromtheme.fishPure prompt colors are now reactively applied via
--on-variablehandlers in therose-pine/fishconf.d integration. No manual configuration needed — colors follow the active Rosé Pine theme variant automatically.Dependencies
conf.d/rose-pine-pure.fish)🤖 Generated with Claude Code