fix: code quality, security hardening, and test coverage#12
Merged
simonovic86 merged 2 commits intomainfrom Mar 5, 2026
Merged
fix: code quality, security hardening, and test coverage#12simonovic86 merged 2 commits intomainfrom
simonovic86 merged 2 commits intomainfrom
Conversation
Extract tick loop logic from cmd/igord/main.go into internal/runner for testability. Deduplicate captureState/replayResume (3 copies) into internal/wasmutil. Update HOSTCALL_ABI.md from "Design Draft" to reflect implemented state. Add WASM hash mismatch and receipt corruption tests. Flag unimplemented spec items (CM-5, OA-2, EI-11) in status doc. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace MustInstantiate with error-returning Instantiate across all WASM init sites. Extract shared tick timeout constant to config.TickTimeout. Unify manifest sidecar loading into pkg/manifest.LoadSidecarData. Fix CI to install TinyGo before tests so WASM integration tests run. Add test coverage reporting. Add validateIncomingManifest and LoadSidecarData tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make checkso WASM integration tests actually run in CI; add test coverage reportingMustInstantiate(panics) with error-returningInstantiateacross 5 call sites (runtime, replay, simulator, tests)config.TickTimeout(100ms) used by agent, replay, and simulator — eliminates 3 duplicated literalsmanifest.LoadSidecarDatareplaces 3 independent implementations (runner, migration, simulator)validateIncomingManifesttests (accept, disabled, price, memory, capability, nil policy) + 4LoadSidecarDatatestsTest plan
go test ./...— all 19 packages passgo vet ./...— clean🤖 Generated with Claude Code