Skip to content

docs: Dependabot preflight + widened merge review rule#15

Merged
simonsangla merged 1 commit intomainfrom
docs/instruction-updates
Apr 16, 2026
Merged

docs: Dependabot preflight + widened merge review rule#15
simonsangla merged 1 commit intomainfrom
docs/instruction-updates

Conversation

@simonsangla
Copy link
Copy Markdown
Owner

Summary

Updates AGENTS.md Execution Discipline section based on new verified learning:

  1. Dependabot preflight — check gh pr list --author app/dependabot --state open before each batch; resolve or disposition any affecting current work
  2. Widened merge review rule — from "PR comments + bot/agent feedback" to include formal reviews AND relevant automated review findings (CodeQL, Copilot, Dependabot, Snyk annotations)

External ~/.claude/skills/repo-bootstrap/SKILL.md updated in parallel with the same rules plus a storage-location note (canonical-for-this-machine now; versioned shared skills repo flagged as future migration candidate for portability).

Evidence

This repo currently has 5 open Dependabot PRs (#1-#5) that pre-date this batch — exactly the kind of signal the new preflight rule surfaces.

Checklist

  • lint passes
  • typecheck passes
  • test passes (6/6)
  • build passes
  • No app code changes
  • No dependency changes

- Preflight: check `gh pr list --author app/dependabot --state open`
  before each batch; resolve or disposition any affecting current batch
- Merge rule: widened from "PR comments + bot/agent feedback" to
  "PR comments, formal reviews, bot/agent code review feedback, AND
  relevant automated review findings (CodeQL, Copilot, Dependabot, Snyk)"

External repo-bootstrap SKILL.md updated in parallel with same additions
plus storage-location note (canonical-for-this-machine, versioned shared
skills repo as future migration candidate).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@simonsangla simonsangla merged commit a1a5287 into main Apr 16, 2026
1 check passed
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the AGENTS.md documentation to provide more detailed instructions for AI agents regarding PR reviews and preflight checks. It expands the merge checklist to include formal reviews and automated findings, and adds a requirement to check for open Dependabot PRs. A review comment suggests optimizing the gh CLI commands for better agent compatibility by using JSON output and providing a specific command for check-run annotations.

Comment thread AGENTS.md
Comment on lines +23 to +26
- `gh pr view <number> --comments` — inline + conversation comments
- `gh pr view <number> --json reviews` — formal reviews
- `gh pr checks <number>` — automated review findings (CodeQL, Copilot review, Dependabot, Snyk, etc.)
- Any bot/agent output in check-run annotations
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For AI agents, using a consistent JSON output format is more reliable and efficient than mixing text and JSON. Consolidating the gh pr view calls into a single request reduces API overhead. Furthermore, since gh pr checks only provides a high-level status summary, providing a specific command for annotations ensures the agent can actually inspect the 'bot/agent output' required in line 26, which is often where the most critical automated findings reside.

Suggested change
- `gh pr view <number> --comments` — inline + conversation comments
- `gh pr view <number> --json reviews` — formal reviews
- `gh pr checks <number>` — automated review findings (CodeQL, Copilot review, Dependabot, Snyk, etc.)
- Any bot/agent output in check-run annotations
- `gh pr view <number> --json comments,reviews,statusCheckRollup` — comments, reviews, and check status
- `gh api repos/:owner/:repo/check-runs/{check_run_id}/annotations` — detailed findings in check-run annotations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant