Merged
Conversation
mhasself
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
datestring2ctimescript and supportingrename.pymodule. This was used very early on to mass rename output.g3files from the aggregator when we transitioned to using the ctime based naming convention.Motivation and Context
This continues some code clean up effort. The old datestring based format hasn't been used in at least five years, it should be safe to remove this by now -- anyone who has old style files either has renamed them by now, or doesn't care to.
How Has This Been Tested?
Not yet tested. CI will run tests, though I don't expect any impact besides decreased code coverage, since we're removing tests.
Types of changes
Checklist: