Conversation
axf295
reviewed
May 28, 2026
Contributor
axf295
left a comment
axf295
left a comment
There was a problem hiding this comment.
would it be more consistent to use NaN rather than none? or is that harder to serialize or whatever?
just thinking that it would probably simplify a lot of the if else statements
Collaborator
Author
|
I'm happy to use |
Contributor
oh, I guess that doesn't help. I was thinking it would be able ot be interpolated and just return more nans lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
SourceGeninterpolation will error out if fluxes areNone. Fix this by instead returning(position, None)if flux isNone. Forsso's,fluxwill be set toNoneif anyephempoints haveflux = None. Solve the issue raised in PR #28.