Open
Conversation
Member
|
Just a heads up -- I made some changes to the workflows/checks that run here today. You'll need to merge the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the default step_time in
gen_turnaroundinturnarounds.pytostep_time=0.1Motivation and Context
This really should have been the default before probably. I think the ACU maxes out at 0.1s step time.
I think I had set this higher when I was testing very high accelerations.
This might be the cause of the az position errors seen on satp1, but that's uncertain until tested.
The high frequency may over constrain the turnaround or cause very strange ACU behavior if we're sending too many points.
How Has This Been Tested?
This has been tested before.
Types of changes
Checklist: