Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added in a check for Point timestamps to add to update_lines in
_run_trackfunction in ACU agent.This should added code should make sure that the update_lines list always contains at least ~3 * step_times worth of points.
Motivation and Context
We were seeing that the ACU agent
_run_trackfunction was running out of points duringgenerate_scancalls when using non-standard (two_leg, standard_gen, three_leg) turnaround methods. This is because theturnaround_genfunction generates PointTrack points at a step_time (currently 0.05s) that is much lower than the_run_trackstep_time (1.0s). The_run_trackfunction tries to pull ~6 points per loop (which should be ~3 seconds worth of points). Because theturnaround_genuses a much lower step_time, the_run_trackfunction was struggling to keep up with the number of points needed per second. This change should make sure each loop of_run_trackshould always grab at least 3*step_time worth of points.How Has This Been Tested?
Needs to be tested! We should test this on one of the platforms with the two_leg or standard_gen turnaround and watch the # free_position_points during turnarounds.
Types of changes
Checklist: