Merged
Conversation
Otherwise we download all artifacts and the upload job can't find the wheels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR names the wheel artifact upload/download in the deploy workflow. This prevents all artifacts from being downloaded and a directory structure being created that prevents the
pypa/gh-action-pypi-publishaction from finding the wheels.Motivation and Context
While @tristpinsm has been testing the new Rogue6 based pysmurf-controllers he's been tagging release candidates, which generate a build of the docker images and the wheels. The wheel builds fail to publish like in the run below:
https://github.com/simonsobs/socs/actions/runs/24865173924/job/72800578579
I realized that this was going to be true even for official releases.
How Has This Been Tested?
I ran workflow on push with just the build wheel and upload/download artifact bits: https://github.com/simonsobs/socs/actions/runs/24892528248/job/72888756641
Types of changes
Checklist: