Skip to content

Fix PyPI wheel uploads#1044

Merged
BrianJKoopman merged 1 commit intomainfrom
koopman/fix-pypi-upload
Apr 24, 2026
Merged

Fix PyPI wheel uploads#1044
BrianJKoopman merged 1 commit intomainfrom
koopman/fix-pypi-upload

Conversation

@BrianJKoopman
Copy link
Copy Markdown
Member

Description

This PR names the wheel artifact upload/download in the deploy workflow. This prevents all artifacts from being downloaded and a directory structure being created that prevents the pypa/gh-action-pypi-publish action from finding the wheels.

Motivation and Context

While @tristpinsm has been testing the new Rogue6 based pysmurf-controllers he's been tagging release candidates, which generate a build of the docker images and the wheels. The wheel builds fail to publish like in the run below:
https://github.com/simonsobs/socs/actions/runs/24865173924/job/72800578579

I realized that this was going to be true even for official releases.

How Has This Been Tested?

I ran workflow on push with just the build wheel and upload/download artifact bits: https://github.com/simonsobs/socs/actions/runs/24892528248/job/72888756641

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Otherwise we download all artifacts and the upload job can't find the wheels.
@BrianJKoopman BrianJKoopman merged commit e20782b into main Apr 24, 2026
15 checks passed
@BrianJKoopman BrianJKoopman deleted the koopman/fix-pypi-upload branch April 24, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant