tpg366: Make acq process robust to network disruptions#1066
Merged
Conversation
50 tasks
5bcf917 to
77b25d6
Compare
7fea643 to
6223882
Compare
Also rename it to a less generic name.
6223882 to
8c36b3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds error handling to the Pfeiffer TPG366 agent. I separated the driver class out to its own module, renamed it to something more specific (since we have other Pfeiffer devices), and made it a subclass of
TCPInterfaceto enable error handling.Motivation and Context
Resolves #1000.
How Has This Been Tested?
This has been tested in the following scenarios:
From power off:
Through network disconnect:
Through power cycle:
Types of changes
Checklist: