Pysmurf controller updates from p10r1#376
Merged
BrianJKoopman merged 17 commits intodevelopfrom Jan 3, 2023
Merged
Conversation
Member
|
Can you rebase on the latest |
d9c3dc3 to
37d32e9
Compare
7 tasks
BrianJKoopman
requested changes
Dec 20, 2022
Member
BrianJKoopman
left a comment
There was a problem hiding this comment.
A couple comments inline below. Also, I know we talked about this offline, but the latest develop should be merged into this (or things rebased, though I don't know how that'll affect my comments.) That'll update the tests so they don't break. Then if you could write tests for the new tasks, that'd be awesome.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
e075f8b to
8eb7e7d
Compare
for more information, see https://pre-commit.ci
…into pysmurf-controller-p10r1
BrianJKoopman
approved these changes
Jan 3, 2023
Member
BrianJKoopman
left a comment
There was a problem hiding this comment.
Looks good, thanks for adding the new tests!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfixes, better feeds and session data, and a few extra tasks from P10R1 testing .
Description
This PR includes several additions that we made during P10R1, including:
overbias_tesandall_offtasksMotivation and Context
This was used in P10R1
How Has This Been Tested?
P10R1
Types of changes
Checklist:
developbranch.