Skip to content

Pysmurf controller updates from p10r1#376

Merged
BrianJKoopman merged 17 commits intodevelopfrom
pysmurf-controller-p10r1
Jan 3, 2023
Merged

Pysmurf controller updates from p10r1#376
BrianJKoopman merged 17 commits intodevelopfrom
pysmurf-controller-p10r1

Conversation

@jlashner
Copy link
Contributor

@jlashner jlashner commented Dec 7, 2022

Bugfixes, better feeds and session data, and a few extra tasks from P10R1 testing .

Description

This PR includes several additions that we made during P10R1, including:

  • addition of the overbias_tes and all_off tasks
  • Better session-data for bias_steps, including total dets in Rfrac range, and dets per bg in Rfrac range
  • bias_steps publishes Rtes, Rfrac, and Si quantiles to grafana

Motivation and Context

This was used in P10R1

How Has This Been Tested?

P10R1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Unless I am preparing a release, I have opened this PR onto the develop branch.

@BrianJKoopman
Copy link
Member

Can you rebase on the latest develop and force push back here? There's a merge conflict that relates to the restructuring of the repo.

@BrianJKoopman BrianJKoopman added the enhancement New feature or request label Dec 8, 2022
@jlashner jlashner force-pushed the pysmurf-controller-p10r1 branch from d9c3dc3 to 37d32e9 Compare December 14, 2022 19:13
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments inline below. Also, I know we talked about this offline, but the latest develop should be merged into this (or things rebased, though I don't know how that'll affect my comments.) That'll update the tests so they don't break. Then if you could write tests for the new tasks, that'd be awesome.

@jlashner jlashner force-pushed the pysmurf-controller-p10r1 branch from e075f8b to 8eb7e7d Compare December 21, 2022 18:07
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding the new tests!

@BrianJKoopman BrianJKoopman merged commit 1786a24 into develop Jan 3, 2023
@BrianJKoopman BrianJKoopman deleted the pysmurf-controller-p10r1 branch January 3, 2023 15:20
@BrianJKoopman BrianJKoopman mentioned this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants