Skip to content

Adds rotation arg to magpie#400

Merged
BrianJKoopman merged 1 commit intodevelopfrom
magpie_rotation
Feb 1, 2023
Merged

Adds rotation arg to magpie#400
BrianJKoopman merged 1 commit intodevelopfrom
magpie_rotation

Conversation

@jlashner
Copy link
Contributor

@jlashner jlashner commented Feb 1, 2023

Adds an argument to magpie that lets you set a wafer's rotation about its center.

Motivation and Context

Necessary for bringing up a focal-plane in lyrebird

How Has This Been Tested?

Tested locally with fake data.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Unless I am preparing a release, I have opened this PR onto the develop branch.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@BrianJKoopman BrianJKoopman merged commit 9a7b750 into develop Feb 1, 2023
@BrianJKoopman BrianJKoopman deleted the magpie_rotation branch February 1, 2023 15:30
@BrianJKoopman BrianJKoopman mentioned this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants