adds pysmurf-controller tag params #424
Conversation
for more information, see https://pre-commit.ci
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
This looks good to me, just two small comments on the docstrings.
I'll defer to @kmharrington about whether this satisfies #385.
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Changes look good! Just one additional suggestion from me.
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
I have a new question about this. It looks like g3_tag on operations overrides default tags like "oper,bgmap". (Should we always be overriding these?)
I just want to confirm that adding a user defined tag on a stream doesn't override the default "obs,stream" tags.
|
Right, in conjunction with this sodetlib PR, user-defined tags are set through a separate kwarg from the stream type/subtype. So when we test we'll need to test both these PRs together. |
kmharrington
left a comment
kmharrington
left a comment
There was a problem hiding this comment.
Reviewing in combo with this one: simonsobs/sodetlib#336
Looks good to me modulo the one in-line comment. I was able to test passing subtypes to observations with stream with and w/o extra tags. I was also able to test extra tags while taking IVs and noise. The bias steps and bgmaps are throwing errors but I'm told that's due to a different error that has been fixed elsewhere. So assuming the tag implementation is the same between all the operations we should be good here!
|
Great, thanks for testing @kmharrington! @jlashner can we merge simonsobs/sodetlib#336 and then also bump the docker base image for the controller in this PR? |
* adds pysmurf-controller tag params * Update test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix docs and small changes * Fix tests * Adds choices to stream_type * bump sodetlib --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Adds
tagparam to pysmurf-controller operations, which will append a user-provided tag to the end of the g3 stream tag.This + simonsobs/sodetlib#336 resolves #385
Motivation and Context
Helpful for the scheduler to be able to append tags to streams or other sodetlib operations.
How Has This Been Tested?
Not tested yet. This should be tested with simonsobs/sodetlib#336 before merging.
Types of changes
Checklist: