stimulator: Add combined calibration function#237
Conversation
… time for calibrate_tau
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… yseino/stimulator-new_func
BrianJKoopman
changed the base branch from
main
to
yseino/stimulator-update
|
I fixed one wrong parameter name. Fixed code worked using Nextline. |
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
This looks good to me, though I think do_setup needs to get dropped from the args list.
We also need a test for this, which is currently what's failing in the checks list. Please see the contributing guide for details on how to install and then the main readme for how to run the tests locally (the -e on install is needed for local coverage reporting to work). Then add a test in test_stimulator.py. The other existing tests should provide a good example to get started.
|
Sorry I forgot to remove it. I just removed |
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
I added a test for the new function, feel free to PR any improvements separately.
BrianJKoopman
changed the title
3 participants
I made a new function for stimulator calibration. The new function takes data for gain and time-constant with one stream.