wiregrid: Add wiregrid rotation motor voltage to config file#256
Merged
BrianJKoopman merged 3 commits intomainfrom Apr 14, 2026
Merged
wiregrid: Add wiregrid rotation motor voltage to config file#256BrianJKoopman merged 3 commits intomainfrom
BrianJKoopman merged 3 commits intomainfrom
Conversation
for more information, see https://pre-commit.ci
BrianJKoopman
requested changes
Apr 13, 2026
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
This looks good to me, but can you also update the example documentation here:
sorunlib/docs/configuration.rst
Lines 25 to 26 in f4a1007
Add wiregrid motor voltage configuration parameter.
Contributor
Author
|
I modified the |
BrianJKoopman
approved these changes
Apr 14, 2026
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Thanks for the update, looks good!
BrianJKoopman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to change the voltage setting to rotate the wiregrid for SATp2 for a smoother rotation.
So, I added the voltage setting in
wiregrid.py.@BrianJKoopman, could you check the change?