update_obsdb: remove auto-update of bad_books_list#1369
Merged
Conversation
AERAdler
approved these changes
Sep 10, 2025
Contributor
AERAdler
left a comment
AERAdler
left a comment
There was a problem hiding this comment.
Is there a prefect alert that tells us when update_obsdb has failed?
mhasself
force-pushed
the
mhasself/track-bad-books
branch
from
3a8a3ad to
f2b7681
Compare
Member
Author
Yup. |
Member
Author
|
I notice now that my switch from os.walk to glob.glob breaks the system, unless fastwalk is used. Let me find a better solution to that ... converting back to draft for now. |
This reflects how we want to run, in practice, which is to fail until the bad_books file has been manually updated. Also adds --limit option, and speeds up directory scanning by using glob instead of walk.
This especially makes standard processing results a little less verbose when all is going well.
mhasself
force-pushed
the
mhasself/track-bad-books
branch
from
f2b7681 to
0720f4c
Compare
Member
Author
|
@AERAdler -- I tweaked a few more things in here to make it a little easier to test, in the AdvLAT era. Logging is less verbose, in way that should help when trying to find failures in the logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reflects how we want to run, in practice, which is to fail until the bad_books file has been manually updated.
Also adds --limit option, and speeds up directory scanning by using glob instead of walk.