Errors as values update book plan#1651
Merged
Merged
Conversation
Member
Author
|
My only concern here is whether this causes other problems further down the line, I don't think so as the tubes should be completely independent and they get bound into separate books? |
kmharrington
approved these changes
May 29, 2026
Member
kmharrington
left a comment
kmharrington
left a comment
There was a problem hiding this comment.
the timecode and hk books have independent checking to decide if they're ready to be registered, so I don't expect this to cause any errors farther down
Member
Author
|
Given that this is running happily, I am ok to merge at this stage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows progress on other tubes for
update_book_planeven when we error out for a specific tube. Fixes #1650.Also includes updates from monitor-and-profile-update_g3thk_database which allows for monitoring and profiling of the g3thk_database flow.