Add documentation to the module#8
Merged
simontabor merged 4 commits intosimontabor:masterfrom Apr 7, 2019
Merged
Conversation
|
@simontabor Why isn't this merged? |
Contributor
Author
|
@simontabor Any update on this? It's been a while and I noticed it still hasn't merged. |
simontabor
requested changes
Feb 25, 2019
Owner
simontabor
left a comment
simontabor
left a comment
There was a problem hiding this comment.
Hi Daniel, thanks for the contribution! Sorry for the incredibly slow review - I'd done the review then forgot to submit it. My bad entirely.
There are a few things to be fixed up before we merge. Thanks!
Contributor
Author
|
Hi Simon! |
Contributor
Author
|
I've changed things according to your feedback, and pushed the commit with these changes. |
Contributor
Author
|
Any update on this Simon? |
Contributor
Author
|
?? |
simontabor
approved these changes
Apr 7, 2019
Owner
|
Merged! @danielgraycode sorry for taking so long to do this, really appreciate the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added some documentation to make it easier for users to understand and use the module.