New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: Fueler #10015
Request: Fueler #10015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look and give another go
hi @PratyushJayachandran , I have updated the svg file could you please take a look into it . |
@PratyushJayachandran Did you get a chance to look at fueler svg . Does it have still same issue? |
I'll do by next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution & updates, @namrata18s 👍🏻
However, your SVG has now been horizontally stretched. It should measure 24dp in height while retaining the same proportionate width (~23.040dp in this case) and be aligned centrally on the canvas. When I resize & realign your version to match the original I'm also seeing a few minor differences, which can likely be resolved by increasing the precision by 1 decimal place.
Hi @PeterShaggyNoble, you mean setting the precision to 1 while running the SVGO? I was wondering wouldn't the lint run fail in this case? |
No, our icons can have a maximum precision of 5 decimal places, so you can try increasing by 1 place in your optimisation process until you get to a point where you can't see a difference between your version and the original. Without trying it myself, I'd say this one will need a precision of 3, but we might get away with 2. |
As @PeterShaggyNoble mentioned the contributed icon is not retaining the dimension ratio of the original icon. Please scale proportionally. Only one of the dimensions(vertical in this case) needs to be 24px. |
Are you still working on this one, @namrata18s? |
@adamrusted, which file did you base your version on? I'm seeing quite a few differences when comparing it with the one in the header. EDIT: Seeing the same differences when comparing with the logo in the footer; here's an example, with yours in red. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm must be looking at the wrong source file. When I resize the one in the header to 24dp in height, it's coming in at 23.04dp in width, whereas Adam's is 23.05 wide 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for starting the contribution @namrata18s!
And special thanks to @adamrusted and @PeterShaggyNoble for finishing it up 🎉
# New Icons - Anycubic (#10466) (@adamrusted) - BuySellAds (#10517) (@adamrusted) - Cheerio (#10462) (@adamrusted) - Cloudflare Workers (#10579) (@uncenter) - Clubforce (#10249) (@PeterShaggyNoble) - Elegoo (#10467) (@adamrusted) - EndeavourOS (#7931) (@LitoMore) - Flashforge (#10584) (@ApexDevelopment) - Fueler (#10015) (@namrata18s) - Google Authenticator (#10454) (@PeterShaggyNoble) - Google Chronicle (#10548) (@durgeshgowdac) - Li-Ning (#10544) (@Mvlprem) - Lucia (#10625) (@uncenter) - Malt (#9213) (@Ash-Crow) - Pixelfed (#10526) (@adamrusted) - Rich (#10329) (@PeterShaggyNoble) - Spaceship (#9721) (@zcraber) - TrueUp (#10582) (@durgeshgowdac) - Watchtower (#10522) (@nirvikpurkait) - Xiaohongshu (#10128) (@LitoMore) - Zed Industries (#10563) (@uncenter) # Updated Icons - Air India (#9322) (@wwwescape) - Logitech (#10430) (@adamrusted) - Western Digital (#10415) (@adamrusted)
Issue: closes #9977
Similarweb rank:
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Colour from website stylesheet.
Steps taken to process .svg (expand)
I took the logo from website-header
I used Inkspace for processing:
resized canvas appropriately, updating the viewport to 0 0 24 24
resized content appropriately
centered content horizontally and vertically
converted to monochromatic
I exported from Inkscape with the option 'optimised .svg'
I used npx svgo to further optimise
I annotated the file
I ran the lint task to check for errors ->
icon-size and icon-centered
I adjusted the logo accurately to the canvas for icon-size
I used npx svgo -p 2 and re-ran lint task -> lint succeeded