New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lucia icon #10625
Add Lucia icon #10625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me, @uncenter - just one small change and a question before merging.
_data/simple-icons.json
Outdated
{ | ||
"title": "Lucia", | ||
"hex": "5F57FF", | ||
"source": "https://lucia-auth.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the icon at the current source URL, but it is present at:
"source": "https://lucia-auth.com", | |
"source": "https://v2.lucia-auth.com", |
Uh well actually I specifically didn't merge that suggestion since the v2 version of their website is outdated. They currently have v3 out. I reached out to the project maintainer and I'm waiting to hear back. Apologies for the miscommunication! I'll make a PR to update the source depending on what the maintainer says. |
It does include the icon, though, which is the main thing that concerns us. If they update the main site to include it, or they provide us within an alternative URL, then we can update our |
# New Icons - Anycubic (#10466) (@adamrusted) - BuySellAds (#10517) (@adamrusted) - Cheerio (#10462) (@adamrusted) - Cloudflare Workers (#10579) (@uncenter) - Clubforce (#10249) (@PeterShaggyNoble) - Elegoo (#10467) (@adamrusted) - EndeavourOS (#7931) (@LitoMore) - Flashforge (#10584) (@ApexDevelopment) - Fueler (#10015) (@namrata18s) - Google Authenticator (#10454) (@PeterShaggyNoble) - Google Chronicle (#10548) (@durgeshgowdac) - Li-Ning (#10544) (@Mvlprem) - Lucia (#10625) (@uncenter) - Malt (#9213) (@Ash-Crow) - Pixelfed (#10526) (@adamrusted) - Rich (#10329) (@PeterShaggyNoble) - Spaceship (#9721) (@zcraber) - TrueUp (#10582) (@durgeshgowdac) - Watchtower (#10522) (@nirvikpurkait) - Xiaohongshu (#10128) (@LitoMore) - Zed Industries (#10563) (@uncenter) # Updated Icons - Air India (#9322) (@wwwescape) - Logitech (#10430) (@adamrusted) - Western Digital (#10415) (@adamrusted)
Issue: closes #10622.
Similarweb rank: https://www.similarweb.com/website/lucia-auth.com
Lucia also has 6.9k+ stars on GitHub.
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
N/A