Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Malt icon #9213

Merged
merged 10 commits into from
Mar 15, 2024
Merged

Add Malt icon #9213

merged 10 commits into from
Mar 15, 2024

Conversation

Ash-Crow
Copy link
Contributor

@Ash-Crow Ash-Crow commented Aug 4, 2023

malt

Issue: closes #6361

Similarweb rank: 43,313

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Icon taken from the previous PR (Malt #6362 ), I just removed the wordmark, adapted the viewport and made the changes asked in the contribution guidelines.
  • Color taken directly from the official logo.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 4, 2023
@Ash-Crow Ash-Crow changed the title Malt Add Malt icon Aug 4, 2023
@Ash-Crow
Copy link
Contributor Author

Ash-Crow commented Aug 7, 2023

I see that some tests have failed but I don't know how to fix the svg file so that they pass.

PratyushJayachandran
PratyushJayachandran requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may apply the suggestion to fix the issues.

icons/malt.svg Outdated Show resolved Hide resolved
Ash-Crow and others added 2 commits August 9, 2023 10:40
@Ash-Crow @PratyushJayachandran
Update icons/malt.svg
624e8db 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@Ash-Crow
Remove newline
42ae5b9
@Ash-Crow
Copy link
Contributor Author

Ash-Crow commented Aug 9, 2023

You may apply the suggestion to fix the issues.

Thanks! It seems like it worked. Can you please explain what was the problem and how you fixed it?

@PratyushJayachandran
Copy link
Member

You may apply the suggestion to fix the issues.

Thanks! It seems like it worked. Can you please explain what was the problem and how you fixed it?

The icon was not centered properly. Sometimes this happens after SVGO conversion. Trimmed down source, ran it through SVGO, fixed it on my editor and then optimized it again.

@adamrusted
Copy link
Member

Guidelines would suggest that we can't include just the icon.
Thoughts, @simple-icons/icon-review?
image

@adamrusted adamrusted added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed in discussion There is an ongoing discussion that should be finished before we can continue and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Aug 15, 2023
@adamrusted
Copy link
Member

Given no feedback, happy for you to make a call on this, @Ash-Crow.
We can either add the full logo with the wordmark, contact them directly and ask for permission to just user the icon, or shut this PR down and I'll mark the issue as won't add.

@PeterShaggyNoble
Copy link
Member

I agree with @adamrusted's interpretation of their guidelines; that we can't use the icon on its own. This is backed up by the fact that they only make the full logo available for download in their media kit. I've always been of the opinion that, as an icon library, we shouldn't have any logos in our collection. But I'm in the minority on that and the precedent has long since been set! 😆

@Ash-Crow, could you update this PR to use the full logo, please?

@PeterShaggyNoble PeterShaggyNoble added changes requested and removed in discussion There is an ongoing discussion that should be finished before we can continue labels Nov 21, 2023
@PeterShaggyNoble
Copy link
Member

Are you still working on this one, @Ash-Crow?

@Ash-Crow
Copy link
Contributor Author

The previous task had been closed because the contributor used the full wordmark and was asked to just put the logo...

I'll try to contact Malt first, if that's ok with you.

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Dec 11, 2023
@PeterShaggyNoble
Copy link
Member

Have you has a response from them, @Ash-Crow?

@PeterShaggyNoble PeterShaggyNoble self-assigned this Mar 14, 2024
@PeterShaggyNoble
Copy link
Member

Updated to use the full logo, based on this SVG found at source.

@service-paradis service-paradis merged commit b02abce into simple-icons:develop Mar 15, 2024
3 checks passed
@github-actions github-actions bot removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Mar 15, 2024
@github-actions github-actions bot mentioned this pull request Mar 17, 2024
Merged
mondeja added a commit that referenced this pull request Mar 17, 2024
@mondeja
Release 21 new icons and 3 updated icons (v11.9.0)
403e4e9 
# New Icons

- Anycubic (#10466) (@adamrusted)
- BuySellAds (#10517) (@adamrusted)
- Cheerio (#10462) (@adamrusted)
- Cloudflare Workers (#10579) (@uncenter)
- Clubforce (#10249) (@PeterShaggyNoble)
- Elegoo (#10467) (@adamrusted)
- EndeavourOS (#7931) (@LitoMore)
- Flashforge (#10584) (@ApexDevelopment)
- Fueler (#10015) (@namrata18s)
- Google Authenticator (#10454) (@PeterShaggyNoble)
- Google Chronicle (#10548) (@durgeshgowdac)
- Li-Ning (#10544) (@Mvlprem)
- Lucia (#10625) (@uncenter)
- Malt (#9213) (@Ash-Crow)
- Pixelfed (#10526) (@adamrusted)
- Rich (#10329) (@PeterShaggyNoble)
- Spaceship (#9721) (@zcraber)
- TrueUp (#10582) (@durgeshgowdac)
- Watchtower (#10522) (@nirvikpurkait)
- Xiaohongshu (#10128) (@LitoMore)
- Zed Industries (#10563) (@uncenter)

# Updated Icons

- Air India (#9322) (@wwwescape)
- Logitech (#10430) (@adamrusted)
- Western Digital (#10415) (@adamrusted)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@service-paradis service-paradis service-paradis approved these changes

@PratyushJayachandran PratyushJayachandran Awaiting requested review from PratyushJayachandran

Assignees

@PeterShaggyNoble PeterShaggyNoble

Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Malt
5 participants
@Ash-Crow @PratyushJayachandran @adamrusted @PeterShaggyNoble @service-paradis