Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Western Digital #10415

Merged

Conversation

adamrusted
Copy link
Member

image

Issue: closes #10389

Similarweb rank: 13,758

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

A lot of excess points in this one - so reduced right down. Chose the purple, as it seems they use a gradient of the purple / pink / blue across socials etc.

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Feb 8, 2024
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some hairline differences in most of the corners but I don't think we need worry about them. There is, however, a more significant difference running down the left edge of the first shape (yours in red). I'm OK if we want to fix the imperfection in the second shape, as you have. Although I do personally feel it's significant enough that we should consider keeping it.

Tough call on the colour, I would have initially said black, but looking at their Facebook, etc., I think you're right to go with one of the icon's colours and, as they also use it for the "TM", I think the purple is the best choice.

@adamrusted
Copy link
Member Author

I'd tried to delete a load of redundant points in the path, so that's what is causing the issue, @PeterShaggyNoble!
I've kept the extra points in those straight lines, just removing the imperfection in the middle shape.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, that's somehow introduced some additional excess nodes and increased some of the differences I was seeing in the corners 🤔 Try this unoptimised path; I managed to remove a good few nodes without introducing any differences that I can see, other than fixing the imperfection in the second shape.

M1.4902344,4.6210938C0.17507843,4.624642 -0.49321232,6.2039057 0.41992188,7.1503906 1.5777736,8.3056877 2.7339168,9.4627146 3.8906254,10.619142c2.406081,2.381666 4.8092221,4.766253 7.2031246,7.160156l1.070312,1.115234c0.940245,0.952574 2.561365,0.265849 2.53125,-1.072265v-3.425782c-0.0105,-0.824798 -0.677142,-1.490573 -1.501953,-1.5H9.0371094C7.5888125,12.906048 6.4123114,11.729547 6.421875,10.28125V6.1210938c-0.0105,-0.8247978 -0.6771423,-1.4905734 -1.5019531,-1.5zm9.2617186,0C9.4358626,4.6229261 8.7659105,6.2032323 9.6796875,7.1503906 13.61164,11.077814 17.539063,15.009766 21.468751,18.939454 22.40833,19.891274 24.028287,19.206292 24,17.869141v-3.429688c-0.0105,-0.824798 -0.677142,-1.490573 -1.501953,-1.5 -1.400658,0.01371 -2.800842,-0.01834 -4.201172,-0.04297 -1.447534,0.0085 -2.622833,-1.167707 -2.613281,-2.615234V6.1210938c-0.0105,-0.8247978 -0.677142,-1.4905734 -1.501953,-1.5zm8.273438,0c-1.351646,-0.0073 -2.012867,1.6451254 -1.029297,2.5722656l3.43164,3.4296876c0.947158,0.913777 2.527465,0.243825 2.529297,-1.0722658V6.1210938c-0.01048,-0.8240482 -0.675952,-1.4895225 -1.5,-1.5z

Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
@PeterShaggyNoble PeterShaggyNoble merged commit 4ce69b9 into simple-icons:develop Mar 14, 2024
3 checks passed
@adamrusted adamrusted deleted the update/western-digital branch March 15, 2024 11:08
mondeja added a commit that referenced this pull request Mar 17, 2024
# New Icons

- Anycubic (#10466) (@adamrusted)
- BuySellAds (#10517) (@adamrusted)
- Cheerio (#10462) (@adamrusted)
- Cloudflare Workers (#10579) (@uncenter)
- Clubforce (#10249) (@PeterShaggyNoble)
- Elegoo (#10467) (@adamrusted)
- EndeavourOS (#7931) (@LitoMore)
- Flashforge (#10584) (@ApexDevelopment)
- Fueler (#10015) (@namrata18s)
- Google Authenticator (#10454) (@PeterShaggyNoble)
- Google Chronicle (#10548) (@durgeshgowdac)
- Li-Ning (#10544) (@Mvlprem)
- Lucia (#10625) (@uncenter)
- Malt (#9213) (@Ash-Crow)
- Pixelfed (#10526) (@adamrusted)
- Rich (#10329) (@PeterShaggyNoble)
- Spaceship (#9721) (@zcraber)
- TrueUp (#10582) (@durgeshgowdac)
- Watchtower (#10522) (@nirvikpurkait)
- Xiaohongshu (#10128) (@LitoMore)
- Zed Industries (#10563) (@uncenter)

# Updated Icons

- Air India (#9322) (@wwwescape)
- Logitech (#10430) (@adamrusted)
- Western Digital (#10415) (@adamrusted)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update: Western Digital
2 participants