-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added watchtower #10522
Added watchtower #10522
Conversation
Every test, lint passed locally, github action failed due to:
Can we re-run the checks? |
Hi @nirvikpurkait, it should be a connection issue related to your local environment. As you can see the HTTP request timed out when connecting to a GitHub public URL. You can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as manual vectorisations go, this is nigh on perfect - very nice work, @nirvikpurkait 👍🏻
It does line up a little better if the height is resized to 24dp but I don't thing the differences are significant enough to block us from merging this as-is, but I'll ask one of the @simple-icons/pr-reviewers to throw another eye over it, too.
For the colour, I think we should go with #2d383e
, which is the website's background colour - what do you reckon?
Looks good to me, good job @nirvikpurkait 🎉! For the color I would opt for the header background color ( |
# New Icons - Anycubic (#10466) (@adamrusted) - BuySellAds (#10517) (@adamrusted) - Cheerio (#10462) (@adamrusted) - Cloudflare Workers (#10579) (@uncenter) - Clubforce (#10249) (@PeterShaggyNoble) - Elegoo (#10467) (@adamrusted) - EndeavourOS (#7931) (@LitoMore) - Flashforge (#10584) (@ApexDevelopment) - Fueler (#10015) (@namrata18s) - Google Authenticator (#10454) (@PeterShaggyNoble) - Google Chronicle (#10548) (@durgeshgowdac) - Li-Ning (#10544) (@Mvlprem) - Lucia (#10625) (@uncenter) - Malt (#9213) (@Ash-Crow) - Pixelfed (#10526) (@adamrusted) - Rich (#10329) (@PeterShaggyNoble) - Spaceship (#9721) (@zcraber) - TrueUp (#10582) (@durgeshgowdac) - Watchtower (#10522) (@nirvikpurkait) - Xiaohongshu (#10128) (@LitoMore) - Zed Industries (#10563) (@uncenter) # Updated Icons - Air India (#9322) (@wwwescape) - Logitech (#10430) (@adamrusted) - Western Digital (#10415) (@adamrusted)
Issue: closes #10478
Similarweb rank:
839,752
Consideration:
Github start: 16.3k
Repository is still active
star history is upward trajectory
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description