Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Anycubic #10466

Merged
merged 6 commits into from Mar 14, 2024
Merged

Add Anycubic #10466

merged 6 commits into from Mar 14, 2024

Conversation

adamrusted
Copy link
Member

@adamrusted adamrusted commented Feb 14, 2024

image

Issue: contributes toward #10464

Similarweb rank: 55,128

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG taken from page 2 of this PDF found at source.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Feb 14, 2024
Copy link
Member

@Mvlprem Mvlprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamrusted I think we should just use the cube as logo, that's what they are using on their social media platforms to represent their brand so we should be fine with just the cube. You can grab it from Anycubic Kobra 2 Neo manual.

@adamrusted
Copy link
Member Author

@Mvlprem - this is now a manual vectorization based on the SVG found in that PDF you mentioned. In order to make it 'recognizably' simple I've had to generate the icon myself and included a 0.5pt gap. I've got a version with a 0.2pt gap if this is deemed to extreme.

Copy link
Member

@Mvlprem Mvlprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamrusted I don't think we need to make any gaps at all. There are already some gaps in place, take a look at this image from their website footer.

I've made one from the source pdf feel free to use and let me know what you think.

<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Testing</title><path d="m6.761.533 10.706 10.301 6.494.63-8.471-7.449L6.761.533ZM6.591.6 0 12.465l7.354 10.978 9.939-12.509L6.591.6Zm10.892 10.397L7.525 23.468l8.649-3.14L24 11.579l-6.517-.582Z"/></svg>

@adamrusted
Copy link
Member Author

@adamrusted I don't think we need to make any gaps at all. There are already some gaps in place, take a look at this image from their website footer.

Yeah, I've made the gaps more pronounced because our primary use-case for icons is with shields.io, and the current gaps do not display well there! @Mvlprem

@Mvlprem
Copy link
Member

Mvlprem commented Feb 22, 2024

@adamrusted Well in that case I'll request a review from someone else cause i don't know how to compare it with source I've never worked with these type of icons

@adamrusted
Copy link
Member Author

No worries, unfortunately we do need to take some 'artistic liberties' with some icons that wouldn't display well...

@PeterShaggyNoble
Copy link
Member

Has the source PDF been updated or have I been staring at icons so long today that I've gone blind? The only icon I can see on the referenced page, or in the whole PDF, is in the QR code, which is a PNG.

@Mvlprem
Copy link
Member

Mvlprem commented Feb 23, 2024

Has the source PDF been updated or have I been staring at icons so long today that I've gone blind? The only icon I can see on the referenced page, or in the whole PDF, is in the QR code, which is a PNG.

I guess you are going through the pdf mentioned in description, but that's not the source. I've asked rusty to use this pdf you can find the logo in page 1.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd agree with @Mvlprem here: if the source icon already includes gaps then we should run with those rather than increasing them.

@adamrusted
Copy link
Member Author

Do not like how this looks at our smaller sizes, but changes made @Mvlprem and @PeterShaggyNoble.

@PeterShaggyNoble PeterShaggyNoble merged commit 2d16401 into simple-icons:develop Mar 14, 2024
3 checks passed
@adamrusted adamrusted deleted the add/anycubic branch March 15, 2024 11:07
mondeja added a commit that referenced this pull request Mar 17, 2024
# New Icons

- Anycubic (#10466) (@adamrusted)
- BuySellAds (#10517) (@adamrusted)
- Cheerio (#10462) (@adamrusted)
- Cloudflare Workers (#10579) (@uncenter)
- Clubforce (#10249) (@PeterShaggyNoble)
- Elegoo (#10467) (@adamrusted)
- EndeavourOS (#7931) (@LitoMore)
- Flashforge (#10584) (@ApexDevelopment)
- Fueler (#10015) (@namrata18s)
- Google Authenticator (#10454) (@PeterShaggyNoble)
- Google Chronicle (#10548) (@durgeshgowdac)
- Li-Ning (#10544) (@Mvlprem)
- Lucia (#10625) (@uncenter)
- Malt (#9213) (@Ash-Crow)
- Pixelfed (#10526) (@adamrusted)
- Rich (#10329) (@PeterShaggyNoble)
- Spaceship (#9721) (@zcraber)
- TrueUp (#10582) (@durgeshgowdac)
- Watchtower (#10522) (@nirvikpurkait)
- Xiaohongshu (#10128) (@LitoMore)
- Zed Industries (#10563) (@uncenter)

# Updated Icons

- Air India (#9322) (@wwwescape)
- Logitech (#10430) (@adamrusted)
- Western Digital (#10415) (@adamrusted)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants