Add Google Authenticator #10454
Merged
Add Google Authenticator #10454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterShaggyNoble
added
the
new icon
|
For reference, the monochrome theme on my phone does the following to the icon: |
|
Didn't think to try that, @adamrusted 👍🏻 Before I update, though, is that an official Google theme or a 3rd-party one? |
It's default on Android from what I can tell, you can Override app buttons with a colour, and it'll display a monochrome treatment if the brand/product has provided it |
|
Does this look right to you, @adamrusted?
|
PeterShaggyNoble
requested review from
service-paradis,
PratyushJayachandran and
a team
PratyushJayachandran
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Thank you for the contribution @PeterShaggyNoble!
The source is not the best but we can tackle that later once google updates it across their websites since they are still showing the old logo at places where we could have fetched the original SVG from.
mondeja
added a commit
that referenced
this pull request
Mar 17, 2024
# New Icons - Anycubic (#10466) (@adamrusted) - BuySellAds (#10517) (@adamrusted) - Cheerio (#10462) (@adamrusted) - Cloudflare Workers (#10579) (@uncenter) - Clubforce (#10249) (@PeterShaggyNoble) - Elegoo (#10467) (@adamrusted) - EndeavourOS (#7931) (@LitoMore) - Flashforge (#10584) (@ApexDevelopment) - Fueler (#10015) (@namrata18s) - Google Authenticator (#10454) (@PeterShaggyNoble) - Google Chronicle (#10548) (@durgeshgowdac) - Li-Ning (#10544) (@Mvlprem) - Lucia (#10625) (@uncenter) - Malt (#9213) (@Ash-Crow) - Pixelfed (#10526) (@adamrusted) - Rich (#10329) (@PeterShaggyNoble) - Spaceship (#9721) (@zcraber) - TrueUp (#10582) (@durgeshgowdac) - Watchtower (#10522) (@nirvikpurkait) - Xiaohongshu (#10128) (@LitoMore) - Zed Industries (#10563) (@uncenter) # Updated Icons - Air India (#9322) (@wwwescape) - Logitech (#10430) (@adamrusted) - Western Digital (#10415) (@adamrusted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: closes #7718
Similarweb rank: n/a
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Tried a couple of different things with cut-outs, but none of them really worked. Went with the standard Google blue for the colour.