add: mysql driver and new mysql/mariadb schema #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InvalidJoker
requested changes
Sep 9, 2025
controller-runtime/src/main/kotlin/app/simplecloud/controller/runtime/database/Database.kt
Outdated
Show resolved
Hide resolved
FllipEis
requested changes
Sep 9, 2025
controller-runtime/src/main/kotlin/app/simplecloud/controller/runtime/database/Database.kt
Outdated
Show resolved
Hide resolved
InvalidJoker
reviewed
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/605843163013316634/1414862027964416021
This pull request adds support for MySQL databases to the controller runtime, improving compatibility and flexibility. The main changes involve updating dependencies, configuration, and schema handling to support MySQL alongside existing databases.
Database support improvements:
mysql-connector-javaas a dependency incontroller-runtime/build.gradle.ktsand defined it ingradle/libs.versions.tomlfor proper version management. [1] [2] [3]Database.setup()method inDatabase.ktto select the correct schema file (/schema-mysql.sqlfor MySQL/MariaDB,/schema.sqlotherwise) based on the current SQL dialect.Database.ktby parsing each command with jOOQ’s parser and adding error handling for better reliability during schema setup.Codebase maintenance:
SQLDialectandDSLinDatabase.ktto support dialect-based schema selection and parsing.Info