Cancel upcoming BD SMSs #5528
Merged
Cancel upcoming BD SMSs #5528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aagrawalrtsl
reviewed
Feb 4, 2025
| class CancelBangladeshStaleExperiments < ActiveRecord::Migration[6.1] | ||
| def up | ||
| Experimentation::Experiment.upcoming.where(experiment_type: 'stale_patients').each do |experiment| | ||
| experiment.destroy # ...because we need the associated notifications gone too |
Contributor
There was a problem hiding this comment.
I am not sure, but would this remove the patients from the treatment group, and destroy that group as well ?
Contributor
Author
There was a problem hiding this comment.
thank you. that's a good catch. patch would be up in a bit
aagrawalrtsl
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story card: sc-14668
Because
Stale patient experiments use up credit meant for current patients
This addresses
Cancelling the experiments for stale patients
Test instructions
destroy) in prod to match (1)