Skip to content

Conversation

@igbanam
Copy link
Contributor

@igbanam igbanam commented Oct 16, 2025

Story card: sc-16860

Because

When both tags are used, both tags need to be enabled for the user to
see the report in the progress tab. This is not necessary since the
action plans in the progress tab is view-only. Only depending on one tag
is sufficient in this case.

This addresses

Using one feature flag only for the progress tab

Test instructions

suite tests

When both tags are used, both tags need to be enabled for the user to
see the report in the progress tab. This is not necessary since the
action plans in the progress tab is view-only. Only depending on one tag
is sufficient in this case.
@igbanam igbanam marked this pull request as ready for review October 17, 2025 07:48
@igbanam igbanam self-assigned this Oct 17, 2025
@igbanam igbanam requested a review from jamiecarter7 October 17, 2025 07:49
Copy link
Contributor

@jamiecarter7 jamiecarter7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should change the flipper flag to a more generic name?
Something like action_plans
Dr Rai feels like the internal name, if we aim to productise Simple a generic approach to naming might be better?

We can drop the progress part as that was specifi to only showing it in the progress tab. This seems to be a complete wrapper now rather than a wrapper inside another wrapper (porgress tab inside dr rai).

@igbanam
Copy link
Contributor Author

igbanam commented Oct 20, 2025

@jamiecarter7 we do need both flags for now. I haven't heard we want to add the component to the progress tab by default. Until that decision, I think we should keep both.

I agree with the naming. It should be action plans. Since this PR was to fix how we used the flags, could we keep the renaming to another PR? It's a small change to rename, but remember we've launched. So changing the name may affect live users.

@igbanam igbanam requested a review from jamiecarter7 October 20, 2025 16:06
Copy link
Contributor

@jamiecarter7 jamiecarter7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamiecarter7
Copy link
Contributor

We can discuss the renaming in another channel

@igbanam igbanam merged commit 646d66f into master Oct 21, 2025
1 check passed
@igbanam igbanam deleted the igbanam/sc-16860/rai-progress-visibility branch October 21, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants