Replace pow() call with ** operator (micro performance optimization)#622
Merged
mblaney merged 1 commit intosimplepie:masterfrom Sep 22, 2019
Ayesh:php56-pow-enhancement
Merged
Replace pow() call with ** operator (micro performance optimization)#622mblaney merged 1 commit intosimplepie:masterfrom Ayesh:php56-pow-enhancement
** operator (micro performance optimization)#622mblaney merged 1 commit intosimplepie:masterfrom
Ayesh:php56-pow-enhancement
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PHP 5.6, we can use the
**operator to achieve the same result. However, because**is a language operator, it is about 4 time faster compared to thepow()function call.This is purely a micro performance optimization, but an optimization without the a BC break or side effects. May I suggest that we replace the
pow()as in the commits?I would also like to mention #620, and it would be great if this could be included in the new release as well, so we can get this into WordPress downstream as well.
Thank you.