Merged
Conversation
ptqa
reviewed
Jun 28, 2022
Contributor
|
I don't really understand the use case for that |
Contributor
Author
If we add new instances and run deploy from application repo (e.g. simplepractice) - there will be running docker containers on those new hosts but they will not be added as a target to appropriate target groups. With these changes we can either run manually to change target group like |
Contributor
Author
|
Or we can add targets manually of course... but why do it if we can automate it |
ptqa
approved these changes
Jun 29, 2022
deveon
approved these changes
Jun 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/170425434
Because we moved tg_attachements from terraform to deploy-tools now we need to manually add targets to target groups when adding new instances.
With this changes we can specify a list of instances instead.