The function xmlEntities should be removed
#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijskh
approved these changes
Jan 27, 2019
Contributor
Author
|
What about merging this PR as well, @jaimeperez? |
Member
Contributor
Author
|
You're right, we have to re-think this once again 😉 Maybe we better resume the conversation at issue #52 to not have the discussion at two places, @jaimeperez 🙂 |
khlr
changed the title
xmlEntities should encode the whole string.xmlEntities should be removed
Member
|
Hi @khlr! I understand there are no pending issues here and we could merge this, right? |
Contributor
Author
|
Exactly :-) |
jaimeperez
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues mentioned in #26 and #52.