Skip to content

Fix SOAP binding Content-Type and SOAPAction processing#314

Merged
thijskh merged 4 commits intorelease-4.xfrom
bugfix/soap-binding-headers
Nov 23, 2022
Merged

Fix SOAP binding Content-Type and SOAPAction processing#314
thijskh merged 4 commits intorelease-4.xfrom
bugfix/soap-binding-headers

Conversation

@tvdijen
Copy link
Copy Markdown
Member

@tvdijen tvdijen commented Nov 22, 2022

Removed incorrect application/soap+xml; this is SOAP 1.2 specific and SAML2 doesn't support that

Comment thread src/SAML2/Binding.php Outdated
@tvdijen
Copy link
Copy Markdown
Member Author

tvdijen commented Nov 22, 2022

I'll take your word for it.. Haven't been able to test it

@thijskh
Copy link
Copy Markdown
Member

thijskh commented Nov 23, 2022

Verified in a test that it needs to be HTTP_SOAPACTION (all caps), indeed conforming with the CGI spec

@tvdijen tvdijen force-pushed the bugfix/soap-binding-headers branch from 760284e to d9e3184 Compare November 23, 2022 12:02
@thijskh thijskh force-pushed the bugfix/soap-binding-headers branch 2 times, most recently from 6b29c76 to 8009ae1 Compare November 23, 2022 12:07
@tvdijen tvdijen force-pushed the bugfix/soap-binding-headers branch from 8009ae1 to 852f76a Compare November 23, 2022 12:16
tvdijen and others added 4 commits November 23, 2022 13:20
Removed incorrect application/soap+xml;  this is SOAP 1.2 specific and SAML2 doesn't support that
@thijskh thijskh force-pushed the bugfix/soap-binding-headers branch from 852f76a to e669194 Compare November 23, 2022 12:20
@thijskh thijskh merged commit 35e4cac into release-4.x Nov 23, 2022
@thijskh thijskh deleted the bugfix/soap-binding-headers branch November 23, 2022 12:50
tvdijen added a commit that referenced this pull request Nov 23, 2022
Removed incorrect application/soap+xml;  this is SOAP 1.2 specific and SAML2 doesn't support that

Co-authored-by: Thijs Kinkhorst <thijs@kinkhorst.com>
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants