Fix Random utility import to use SimpleSAML\Utils\Random#72
Merged
tvdijen merged 3 commits intosimplesamlphp:masterfrom May 7, 2026
Merged
Fix Random utility import to use SimpleSAML\Utils\Random#72tvdijen merged 3 commits intosimplesamlphp:masterfrom
tvdijen merged 3 commits intosimplesamlphp:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
============================================
- Coverage 68.03% 67.79% -0.24%
Complexity 364 364
============================================
Files 25 25
Lines 1220 1211 -9
============================================
- Hits 830 821 -9
Misses 390 390 🚀 New features to boost your workflow:
|
Member
|
The code for generating IDs was not removed, but moved to the IDValue-class: We should probably use that one now.. I think I'm gonna remove the one from SimpleSAMLphp in the future. |
…oaches are deprecated)
Contributor
Author
@tvdijen can you please check again |
tvdijen
reviewed
May 6, 2026
tvdijen
reviewed
May 6, 2026
Member
|
Excellent, thanks @ioigoume ! |
Member
|
Tagged v7.0.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
Randomimports fromSimpleSAML\XML\Utils\RandomtoSimpleSAML\Utils\Random. The XML-namespacedRandomhelper was removed fromsimplesamlphp/xml-commonin 2.8.x, so the old import now breaks (or triggers warnings) when projects upgrade. This is a compatibility fix only—ID generation behavior remains unchanged, but the code now works with newerxml-common/SimpleSAMLphp dependency sets.