Fix PHPdoc return tags and a code warning#46
Merged
tvdijen merged 2 commits intosimplesamlphp:release-1.2from Jun 13, 2025
Merged
Fix PHPdoc return tags and a code warning#46tvdijen merged 2 commits intosimplesamlphp:release-1.2from
tvdijen merged 2 commits intosimplesamlphp:release-1.2from
Conversation
Contributor
rcnsheppardp
commented
Jun 13, 2025
rcnsheppardp
commented
- Added @return tags
- Removed additional parameter in function call - if it was intended to be a default, or worked as one a long time ago, it would be caught by the Assert now
- Added @return tags - Removed additional parameter in function call - if it was intended to be a default, or worked as one a long time ago, it would be caught by the Assert now
tvdijen
reviewed
Jun 13, 2025
tvdijen
approved these changes
Jun 13, 2025
tvdijen
pushed a commit
that referenced
this pull request
Jun 13, 2025
* Fix PHPdoc return tags and a code warning - Added @return tags - Removed additional parameter in function call - if it was intended to be a default, or worked as one a long time ago, it would be caught by the Assert now * Revert removal and switch to getOptionalValueValidate()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.