Czech translation for expirycheck module #1
Conversation
|
Hi Jan! First of all, thanks a lot for your work translating this module. Unfortunately, the way translation works today in SimpleSAMLphp, it is not possible to have two dictionaries with the same name. That's the reason why this module is not translated, as it collides with the dictionary with the same name in the preprodwarning module. One way to fix this would be to rename the dictionary (not only the file, but also every use of it inside the module), so that there's no collision. That should be a temporary fix, however, as I think we need to change the translation system into something more standard and easy to use. If you can provide a pull request with the translation, together with the dictionary renamed and the appropriate changes in the module, I'd be glad to merge it. Then it would also be possible to finally add all other translations to it. |
Dictionaries files in expirycheck module renamed in order to solve collision with dictionaries files in preprodwarning module.
|
Hi Jaime, I've made what you've suggested, so it should be ready for merging now. |
|
Merged! Thanks a lot for your work Jan, and sorry for the delay in merging this. Now there's a new item in the translation portal too for others to translate this module to their own languages. Thanks again! |
Added docs for regex consent.disable
Remove hardcoded path to extlib in authgoogle
* Adjusted the silent fail to log a warning when $this->getLdap() fails
the silent fail on searchformultiple(...) did not show anything in the log when actually it was the $this->getLdap() that failed.
* Bugfix: Wrapped the building of authsource config with issets
Not doing this gave me errors about ldap.port and ldap.timeout not being an integer (but NULL) from Configuration.php
Dec 23 08:28:10 simplesamlphp WARNING [94b0f44d76] AttributeAddFromLDAP: exception = exception 'Exception' with message 'ldap:AuthProcess: The option 'ldap.port' is not a valid integer value.' in /Users/remy/git/saml-IdP/lib/SimpleSAML/Configuration.php:737
Stack trace:
#0 /Users/remy/git/saml-IdP/modules/ldap/lib/Auth/Process/BaseFilter.php(267): SimpleSAML_Configuration->getInteger('ldap.port', 389)
#1 /Users/remy/git/saml-IdP/modules/ldap/lib/Auth/Process/AttributeAddFromLDAP.php(172): sspmod_ldap_Auth_Process_BaseFilter->getLdap()
...
* removed the @ as thijskh suggested...
* feature: AttributeCopy can take array for 1 attribute
* Revert "feature: AttributeCopy can take array for 1 attribute"
This reverts commit 78ccac0.
* BaseFilter.php: fix indent and added more isset checks...
* BaseFilter.php: removed an unneeded if ($authsource['search.enable'] ....
Since I moved this code into an if that already only gets executed when authsource['search.enable'] = true it is no longer needed in this check....
Adds further support for php-memcached.
remove DS_Store files
ghost
mentioned this pull request
2 participants
Just expirycheck module translation.