Merged
Conversation
tvdijen
reviewed
Jan 5, 2023
tvdijen
approved these changes
Jan 5, 2023
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
7e3ea19 to
2523634
Compare
This was a mixture of legacy supported options, some of them deprecated, and data types, and also implemented differently in some places than others. This changes it once more but hopefully for the better: * The value is always an array or null/unset. * You can set it to a specific array to get a specific policy. * You can leave it unset/null to keep the default policy. * You can set it to the empty array to signal that you do not want any policy to be sent. * The string and bool types are no longer allowed. All in all this means that we can make code much simpler, a lot less if-branching, and also typewise make use of correct typehints. The behaviour changes are as follows: - We drop the already deprecated option to set it as a string (deprecated in 1.17). - To not send the element you need to change false to []; this was not deprecated before but I believe setting it to false was already broken in master.
thijskh
force-pushed
the
fix-nameidpolicy-config
branch
from
4054d6e to
12a282a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1741 +/- ##
============================================
+ Coverage 42.68% 43.62% +0.93%
Complexity 2207 2207
============================================
Files 83 83
Lines 6192 6192
============================================
+ Hits 2643 2701 +58
+ Misses 3549 3491 -58 |
tvdijen
reviewed
Jan 5, 2023
tvdijen
reviewed
Jan 5, 2023
tvdijen
approved these changes
Jan 6, 2023
thijskh
added a commit
that referenced
this pull request
Jan 6, 2023
This was a mixture of legacy supported options, some of them deprecated, and data types, and also implemented differently in some places than others. This changes it once more but hopefully for the better: * The value is always an array or null/unset. * You can set it to a specific array to get a specific policy. * You can leave it unset/null to keep the default policy. * You can set it to the empty array to signal that you do not want any policy to be sent. * The string and bool types are no longer allowed. All in all this means that we can make code much simpler, a lot less if-branching, and also typewise make use of correct typehints. The behaviour changes are as follows: - We drop the already deprecated option to set it as a string (deprecated in 1.17). - To not send the element you need to change false to []; this was not deprecated before but I believe setting it to false was already broken in master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a mixture of legacy supported options, some of them deprecated, and data types, and also implemented differently in some places than others.
This changes it once more but hopefully for the better:
All in all this means that we can make code much simpler, a lot less if-branching, and also typewise make use of correct typehints.
The behaviour changes are as follows:
falseto[]; this was not deprecated before but I believe setting it to false was already broken in master.