tests: adapt tests to pass, after breaking changes made by CloudFlare #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudFlare has broken API compatibility by changing the error status codes returned for some cases. This broke some tests on the library. Since this library exposes the original status code, users of the library are recommended to check code that uses them against the CloudFlare documentation, to look for changes. Affected cases on this library: 1. When an "A" (IPv4 address) record is being created, if it already exists the API used to produce error code 81057. Now it returns code 81058. 2. When an "A" DNS record is being created, but the content is not a valid IPv4 address, the response code used to be CF error "1004: DNS Validation Error". Now it is "9005: Content for A record must be a valid IPv4 address."
FranciscoKurpiel
changed the title
fho
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloudFlare has broken API compatibility by changing the error status codes returned for some cases. This broke some tests on the library.
Since this library exposes the original status code, users of the library are recommended to check code that uses them against the CloudFlare documentation, to look for changes.
This is the list of changes returned from CloudFlare that affect test code on this library:
A(IPv4 address) record is being created, if it already exists the API used to produce error code81057. Now it returns code81058.ADNS record is being created, but the content is not a valid IPv4 address, the response code used to be CF error1004: DNS Validation Error. Now it is9005: Content for A record must be a valid IPv4 address..