Skip to content

Scenes generator #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjaminreid merged 3 commits into from
Mar 7, 2018
Merged

Scenes generator #32

benjaminreid merged 3 commits into from
Mar 7, 2018

Conversation

@benjaminreid
Copy link
Contributor

@benjaminreid benjaminreid commented Mar 6, 2018

This generates a connected scene

@benjaminreid benjaminreid self-assigned this Mar 6, 2018
@benjaminreid benjaminreid requested a review from craigcoles March 7, 2018 09:58
craigcoles
craigcoles approved these changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@craigcoles craigcoles left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 🚪 🏃 💨

Is it worth also detecting what navigation they are using and outputting some help on how to add it to the router and then navigating to that scene?

@benjaminreid
Copy link
Contributor Author

benjaminreid commented Mar 7, 2018

Good shout, that could be a nice enhancement. But I will merge for now!

@benjaminreid benjaminreid merged commit 499bf7a into master Mar 7, 2018
@benjaminreid benjaminreid deleted the scene-generator branch March 7, 2018 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@craigcoles craigcoles craigcoles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminreid benjaminreid

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benjaminreid @craigcoles