Skip to content

Babelrc fix #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjaminreid merged 1 commit into from
Nov 6, 2018
Merged

Babelrc fix #77

benjaminreid merged 1 commit into from
Nov 6, 2018

Conversation

@benjaminreid
Copy link
Contributor

@benjaminreid benjaminreid commented Nov 6, 2018

Proposed changes

Allow the Babel file that comes over from react-native init rather than our custom one as it has changed over time.

@benjaminreid benjaminreid self-assigned this Nov 6, 2018
craigcoles
craigcoles approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@craigcoles craigcoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@benjaminreid benjaminreid merged commit 5870302 into master Nov 6, 2018
@benjaminreid benjaminreid deleted the babel-fix branch November 6, 2018 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@craigcoles craigcoles craigcoles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminreid benjaminreid

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benjaminreid @craigcoles