show response body for clone#1040
Merged
Merged
Conversation
420077f to
903dcc2
Compare
903dcc2 to
14c9b3b
Compare
geoffrey1330
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the V2 volume clone endpoint:
GET
/api/v2/clusters/{cluster_id}/storage-pools/{pool_id}/volumes/{lvol_id}/clonecan return HTTP 500 because it directly returns:
return lvol_controller.clone_lvol(...)
clone_lvol()returns a tuple, for example(new_lvol_uuid, False)on success or(False, error)on failure, while the route is annotated as:def clone(...) -> bool:
FastAPI tries to serialize/validate that tuple as a boolean and raises
ResponseValidationError.The these changes fixes this by unpacking the tuple, handling the error case explicitly, and returning the created clone using the same V2 creation pattern: