Add --nvme-names to sn configure and --format-4k to sn add-node#859
Merged
wmousa merged 1 commit intoR25.10-Hotfixfrom Jan 30, 2026
Merged
Add --nvme-names to sn configure and --format-4k to sn add-node#859wmousa merged 1 commit intoR25.10-Hotfixfrom
wmousa merged 1 commit intoR25.10-Hotfixfrom
Conversation
Hamdy-khader
approved these changes
Jan 29, 2026
wmousa
force-pushed
the
R25.10-Hotfix-nvme_names
branch
2 times, most recently
from
464dc8e to
589d321
Compare
and also add --format-4k to sn add-node to force format the nvme devices with 4K
wmousa
force-pushed
the
R25.10-Hotfix-nvme_names
branch
from
589d321 to
88d269a
Compare
wmousa
added a commit
that referenced
this pull request
Feb 3, 2026
…es (#859) and also add --format-4k to sn add-node to force format the nvme devices with 4K
wmousa
added a commit
that referenced
this pull request
Feb 4, 2026
…es (#859) and also add --format-4k to sn add-node to force format the nvme devices with 4K
wmousa
added a commit
that referenced
this pull request
Feb 5, 2026
* Prometheus hostpath (#761) * fixed merge conflict * fixed merge conflict * increased k8s fdb memory limit (#740) * added try and except to patch_prometheus_configmap func (#756) * use max_size instead as hugepage memory when set (#754) * use max_size instead as hugepage memory when set * fixed linter issue * fixed type check * fixed: Remove assignment to unused variable e * fixed: Remove extraneous prefix * comment out to using max_size value as hugpages * comment out max_size * setup ramdisk mount * use the max of huge_page_memory and max_size when max_size is set * Update storage_init_job.yaml.j2 * Update storage_init_job.yaml.j2 * Update storage_init_job.yaml.j2 * removed nsenter * fixed Syntax error: end of file unexpected * run systemctl ram mount disk on host * updated core Isolation * inherit from worker pool * schedule admin control replica pod on the different worker * check and compare hugepage before and after apply_config * increased node add to 16 retry * run upto 2 replicas of the ingress controller across workers * support 2 fdb coordinator failure * sleep core isolation job for 5mins * use emptyDir memory medium as socket directory (#783) * added graylog env GRAYLOG_MESSAGE_JOURNAL_MAX_SIZE (#782) * addd endpoint bind_device_to_nvme in kubernetes (#784) * remove fdb customParameters * removed hostpath capacity * Update mongodb.yaml * Update app_k8s.yaml * added check for spdk_container is running * removed helm chart dependency * Revert "removed helm chart dependency" This reverts commit 65ffd7b. * Revert "added check for spdk_container is running" This reverts commit 5f0e729. * Increase total sys HP memory with a buffer .5G for each sn node and and container limit * Change hugepages memory variable from MEM_GEGA to MEM_MEGA * Change hugepages memory variable from MEM_GEGA to MEM_MEGA2 * Add fix to p2p to allow passing non-exist pci * Add option --nvme-names to select nvme devices by their namespace names (#859) and also add --format-4k to sn add-node to force format the nvme devices with 4K * bind device to spdk before formatting it * Fix type issue * Make LVOL_NVMF_PORT_START configurable via environment variable * Fix sn restart with new device - check new pcie against the current ssds list for the node - bind new devices to spdk driver * Fix storage node key error on port allow task * Handle sync delete errors in tasks_runner_sync_lvol_del.py and update task status accordingly * Update env_var * fix --------- Co-authored-by: Geoffrey Israel <israelgeoffrey13@gmail.com> Co-authored-by: hamdykhader <hamdy.khader@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option --nvme-names to select nvme devices by their namespace names
and also add --format-4k to sn add-node to force format the nvme devices with 4K