feat(docker): use build secrets for Dynatrace credentials and add ARM…#3
Merged
feat(docker): use build secrets for Dynatrace credentials and add ARM…#3
Conversation
… platform - Replace ARG-based secret passing with --mount=type=secret in Dockerfile, fixing Docker's SecretsUsedInArgOrEnv lint warning - Add QEMU setup and linux/arm64 platform to CI/CD publish workflow - Move Dynatrace credentials from build-args to secrets in build-push-action Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the .env.telemetry pattern that baked DYNATRACE_LOG_INGEST_URL and DYNATRACE_API_TOKEN into the Docker image at build time. Secrets were extractable from the final image layer — a security vulnerability. Now: - Dockerfile has zero secrets; CMD runs bun directly - CI workflow no longer passes secrets at build time - docker-compose.prod.yml injects Dynatrace vars as runtime env vars - No app code changes needed (logging module already reads process.env) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…untime" This reverts commit 590d8b6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… platform