Fix recursive nested block cleanup during merge edits

Author: cursoragent

apps/sim/lib/copilot/tools/server/workflow/edit-workflow/operations.test.ts

@@ -408,4 +408,39 @@ describe('handleEditOperation nestedNodes merge', () => {
     const helperBlock = Object.values(state.blocks).find((block: any) => block.name === 'Helper')
     expect(helperBlock).toBeDefined()
   })
+
+  it('removes descendants when a nested container child is removed', () => {
+    const workflow = makeNestedLoopWorkflow()
+
+    const { state } = applyOperationsToWorkflowState(workflow, [
+      {
+        operation_type: 'edit',
+        block_id: 'outer-loop',
+        params: {
+          nestedNodes: {
+            replacement: {
+              type: 'function',
+              name: 'Replacement Helper',
+              inputs: { code: 'return 1' },
+            },
+          },
+        },
+      },
+    ])
+
+    expect(state.blocks['inner-loop']).toBeUndefined()
+    expect(state.blocks['inner-agent']).toBeUndefined()
+    expect(
+      state.edges.some((edge: any) => edge.source === 'inner-loop' || edge.target === 'inner-loop')
+    ).toBe(false)
+    expect(
+      state.edges.some((edge: any) => edge.source === 'inner-agent' || edge.target === 'inner-agent')
+    ).toBe(false)
+
+    const replacementBlock = Object.values(state.blocks).find(
+      (block: any) => block.name === 'Replacement Helper'
+    ) as any
+    expect(replacementBlock).toBeDefined()
+    expect(replacementBlock.data?.parentId).toBe('outer-loop')
+  })
 })

apps/sim/lib/copilot/tools/server/workflow/edit-workflow/operations.ts

@@ -298,14 +298,23 @@ function mergeNestedNodesForParent(
   })
 
   const removedIds = new Set<string>()
+  const findChildrenToRemove = (parentId: string) => {
+    Object.entries(modifiedState.blocks).forEach(([childId, child]: [string, any]) => {
+      if (child.data?.parentId === parentId && !removedIds.has(childId)) {
+        removedIds.add(childId)
+        findChildrenToRemove(childId)
+      }
+    })
+  }
   for (const [existingId] of existingChildren) {
     if (!matchedExistingIds.has(existingId)) {
-      delete modifiedState.blocks[existingId]
       removedIds.add(existingId)
+      findChildrenToRemove(existingId)
     }
   }
 
   if (removedIds.size > 0) {
+    removedIds.forEach((id) => delete modifiedState.blocks[id])
     modifiedState.edges = modifiedState.edges.filter(
       (edge: any) => !removedIds.has(edge.source) && !removedIds.has(edge.target)
     )