-
Notifications
You must be signed in to change notification settings - Fork 2.5k
improvement: runpath edges, blocks, active #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/utils/block-ring-utils.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| import { cn } from '@/lib/utils' | ||
|
|
||
| export type BlockDiffStatus = 'new' | 'edited' | null | undefined | ||
|
|
||
| export type BlockRunPathStatus = 'success' | 'error' | undefined | ||
|
|
||
| export interface BlockRingOptions { | ||
| isActive: boolean | ||
| isPending: boolean | ||
| isFocused: boolean | ||
| isDeletedBlock: boolean | ||
| diffStatus: BlockDiffStatus | ||
| runPathStatus: BlockRunPathStatus | ||
| } | ||
|
|
||
| /** | ||
| * Derives visual ring visibility and class names for workflow blocks | ||
| * based on execution, focus, diff, deletion, and run-path states. | ||
| */ | ||
| export function getBlockRingStyles(options: BlockRingOptions): { | ||
| hasRing: boolean | ||
| ringClassName: string | ||
| } { | ||
| const { isActive, isPending, isFocused, isDeletedBlock, diffStatus, runPathStatus } = options | ||
|
|
||
| const hasRing = | ||
| isActive || | ||
| isPending || | ||
| isFocused || | ||
| diffStatus === 'new' || | ||
| diffStatus === 'edited' || | ||
| isDeletedBlock || | ||
| !!runPathStatus | ||
|
|
||
| const ringClassName = cn( | ||
| // Executing block: pulsing success ring with prominent thickness | ||
| isActive && 'ring-[3.5px] ring-[var(--border-success)] animate-ring-pulse', | ||
| // Non-active states use standard ring utilities | ||
| !isActive && hasRing && 'ring-[1.75px]', | ||
| // Pending state: warning ring | ||
| !isActive && isPending && 'ring-[var(--warning)]', | ||
| // Focused (selected) state: brand ring | ||
| !isActive && !isPending && isFocused && 'ring-[var(--brand-secondary)]', | ||
| // Deleted state (highest priority after active/pending/focused) | ||
| !isActive && !isPending && !isFocused && isDeletedBlock && 'ring-[var(--text-error)]', | ||
| // Diff states | ||
| !isActive && | ||
| !isPending && | ||
| !isFocused && | ||
| !isDeletedBlock && | ||
| diffStatus === 'new' && | ||
| 'ring-[#22C55E]', | ||
| !isActive && | ||
| !isPending && | ||
| !isFocused && | ||
| !isDeletedBlock && | ||
| diffStatus === 'edited' && | ||
| 'ring-[var(--warning)]', | ||
| // Run path states (lowest priority - only show if no other states active) | ||
| !isActive && | ||
| !isPending && | ||
| !isFocused && | ||
| !isDeletedBlock && | ||
| !diffStatus && | ||
| runPathStatus === 'success' && | ||
| 'ring-[var(--border-success)]', | ||
| !isActive && | ||
| !isPending && | ||
| !isFocused && | ||
| !isDeletedBlock && | ||
| !diffStatus && | ||
| runPathStatus === 'error' && | ||
| 'ring-[var(--text-error)]' | ||
| ) | ||
|
|
||
| return { hasRing, ringClassName } | ||
| } |
1 change: 1 addition & 0 deletions
1
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/utils/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| export * from './auto-layout-utils' | ||
| export * from './block-ring-utils' | ||
| export * from './workflow-execution-utils' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Adding CSS variables to
globals.cssviolates the style guide which states "You should not update the global styles unless it is absolutely necessary." Consider defining--border-successin the Tailwind config or in local component styles instead.Context Used: Context from
dashboard- Avoid editing the globals.css file unless absolutely necessary. Move style changes to local componen... (source)Prompt To Fix With AI