Conversation
meganrm
requested review from
interim17 and
tyler-foster
and removed request for
a team
meganrm
commented
Feb 26, 2025
| @@ -0,0 +1,220 @@ | |||
| import BindingDiagrams from "../components/BindingDiagrams"; | |||
Contributor
Author
There was a problem hiding this comment.
no changes, just moved to a new file
meganrm
added
the
priority
interim17
approved these changes
Feb 26, 2025
Contributor
interim17
left a comment
interim17
left a comment
There was a problem hiding this comment.
Found one possible typo? Otherwise LGTM
src/content/HighAffinity.tsx
Outdated
| </> | ||
| } | ||
| />{" "} | ||
| to compare affinities. K<sub>d</sub> can by determined in this |
tyler-foster
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Estimated review size: small
Need to add the second module content
closes #171
Solution
Moved the existing content into its own file, then added the LowAffinity content, it is not being used anywhere yet.
Type of change
Please delete options that are not relevant.