Merged
Conversation
meganrm
commented
Feb 26, 2025
Comment on lines
+35
to
+36
| kOn: 0.9, | ||
| kOff: 0.01, |
Contributor
Author
There was a problem hiding this comment.
these had to be changed because the new unbinding means to have the same binding affinity the k off rate had to be a lot lower
meganrm
commented
Feb 26, 2025
|
|
||
| const kds = { | ||
| [Module.A_B_AB]: 1, | ||
| [Module.A_B_AB]: 0.75, |
Contributor
Author
There was a problem hiding this comment.
this is a more accurate number for what gets calculated
interim17
approved these changes
Feb 26, 2025
toloudis
reviewed
Feb 27, 2025
| ); | ||
| if (unbindingOccurred) { | ||
| this.currentNumberOfUnbindingEvents++; | ||
| this.currentNumberBound--; |
Contributor
There was a problem hiding this comment.
is there any danger of out-of-bounds stuff happening here?
Contributor
Author
There was a problem hiding this comment.
Not that I can think of. The currentNumberBound is used to graph the product and it’s pretty smooth and consistent. Agents never go away, there’s periodic boundary behind the edges of the viewport
toloudis
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Estimated review size: small
closes #176
When the app updates all the instances, it was only checking unbinding events on agents that overlapped, not ones that were perfectly bound.
Solution
call check if unbind function within step
Type of change
Please delete options that are not relevant.
Steps to Verify: