feat: Camera distance is now scaled to >= 90% of the screen real estate#383
Closed
ShrimpCryptid wants to merge 4 commits intomainfrom
Closed
feat: Camera distance is now scaled to >= 90% of the screen real estate#383ShrimpCryptid wants to merge 4 commits intomainfrom
ShrimpCryptid wants to merge 4 commits intomainfrom
Conversation
jest coverage report 🧪Total coverage
Show files with reduced coverage 🔻Reduced coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time Estimate or Size
Estimated size: small, 5-10 minutes
Problem
Closes #330, a bug where the camera would be zoomed too far out on reset.
Solution
cameraDefaultto be an optional property inTrajectoryFileInfo, soType of change
Please delete options that are not relevant.
Steps to Verify:
simularium-websiterepo to use your local, built version ofvolume-viewer.https://www.dropbox.com/scl/fi/2srfuliyjnu3sr1tlfgwf/cells_2023-10-04.simularium?rlkey=hg35vs9cwrla19eq2m0al81t4Screenshots (optional):
Unchanged: