Feature/only work with 1 type interface for TrajectoryFileInfo#116
Merged
Feature/only work with 1 type interface for TrajectoryFileInfo#116
Conversation
toloudis
approved these changes
Apr 16, 2021
meganrm
approved these changes
Apr 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TrajectoryFileInfoandTrajectoryFileInfoV2) even though only the updated version was being fed to it.updateTrajectoryFileInfoFormat's return type should be the latest version of TrajectoryFileInfo and closes it out
Solution
TrajectoryFileInfowhich now is always the latest versionType of change
Non-breaking change with no change to the UI (just refactoring)
Steps to Verify:
npm ithennpm start, verify everything works like before with local and networked trajectories (minus separate issues we have with networked trajectories currently)